Skip to content

Fix typos in src/ #39606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typos in src/ #39606

wants to merge 2 commits into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 8, 2023

@powerivq From #39602

See typos config in that PR!

These three PR-s are all I have for you.
If you are interested in additional ~1000 typos please do run typos yourself.

@amp-owners-bot amp-owners-bot bot requested a review from powerivq November 8, 2023 15:53
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 8, 2023

Actually I've prepared the 4th PR ...

Here is the typos config for the willing contributor ⚡

[files]
extend-exclude = [
    ".git/",
    "examples/amp-fx-float-in.html",
    "examples/amp-script/todomvc.ssr.js",
    "examples/amp-script/vue-todomvc.js",
    "examples/amphtml-ads/nws.a4a.html",
    "examples/autocomplete-states.example.json",
    "validator/cpp/htmlparser/casetable.h",
    "validator/cpp/htmlparser/data/CaseFolding.txt",
    "validator/cpp/htmlparser/entity.h",
    "validator/cpp/htmlparser/json/testdata/",
    # Lorem ipsum
    "examples/*.amp.html",
    "examples/amp-toggle-theme.html",
    # Are these downloaded?
    "third_party/",
    "3p/vendors/",
    "ads/vendors/",
]
ignore-hidden = false

[default]
extend-ignore-re = [
    "BUILDing",
    "optin=",
    "to optin to experiments",
    "data.optin;",
    "MEDIA-343ded3e",
    "SYSTEMtaco",
    '"FOO.+"',
    "COM--MENT",
    "splacementMappletfeDistantLightmlfeFloodfeFuncAfeFuncBfeFuncGfeFuncRfeGaus",
    "bang=ba;",
    '"bang", "ba"',
    "cbt=ewIBRj20LWkIv_Xk97MIENbBkf8DGMDAvHsiFWNsZWFubXltYWMubWFjcGF3LmNvbTIICAUTGO27CBRCF2NhLXB1Yi0yNjQwNDcyNzcyMzY4NjQySAZYN2DsA3ABegUIAxIBCA",
    'data-videoid="[^"]"',
    'data-shortcode="[^"]+"',
    # HTML entity
    "&[a-z]+;",
    # Known typo
    "col-fourty",
    # Lorem ipsum
    "libero varius",
    "facilisi morbi",
    "facilisis sed",
    "nulla facilisi",
    "Nam nec",
    "Nam porta",
    "Nam dui",
    "Nam elementum",
    "Nam et magna",
    "Nam finibus",
    "Nam lacinia",
    "Nam molestie",
    "Nam pellentesque",
    "Nam posuere",
    "Nam quam",
    "Nam sit amet",
    "Nulla facilisi",
    "ridiculus mus",
    "varius est",
    "varius libero",
    "varius sem",
    "varius suscipit",
    "varius vitae",
]

[default.extend-words]
# Brand
"adition" = "adition"

[default.extend-identifiers]
# Typos
"Wordpress" = "WordPress"

"amp_stads" = "amp_stads"
"IS_UTF8_TRAIL_2ND_BYTE_VALID" = "IS_UTF8_TRAIL_2ND_BYTE_VALID"
# TODO typo
"BASE_TAG_MUST_PRECEED_ALL_URLS" = "BASE_TAG_MUST_PRECEED_ALL_URLS"
"ValidationError_BASE_TAG_MUST_PRECEED_ALL_URLS" = "ValidationError_BASE_TAG_MUST_PRECEED_ALL_URLS"
# Is it a typo??
"enqueAction" = "enqueAction"

@szepeviktor
Copy link
Contributor Author

@powerivq Friendly ping from the past 🏓

@powerivq
Copy link
Contributor

@szepeviktor You have conflicts needing to be resolved.

@szepeviktor
Copy link
Contributor Author

Done 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants