-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix typos in src/ #39606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
szepeviktor
wants to merge
2
commits into
ampproject:main
Choose a base branch
from
szepeviktor:typos3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix typos in src/ #39606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually I've prepared the 4th PR ... Here is the [files]
extend-exclude = [
".git/",
"examples/amp-fx-float-in.html",
"examples/amp-script/todomvc.ssr.js",
"examples/amp-script/vue-todomvc.js",
"examples/amphtml-ads/nws.a4a.html",
"examples/autocomplete-states.example.json",
"validator/cpp/htmlparser/casetable.h",
"validator/cpp/htmlparser/data/CaseFolding.txt",
"validator/cpp/htmlparser/entity.h",
"validator/cpp/htmlparser/json/testdata/",
# Lorem ipsum
"examples/*.amp.html",
"examples/amp-toggle-theme.html",
# Are these downloaded?
"third_party/",
"3p/vendors/",
"ads/vendors/",
]
ignore-hidden = false
[default]
extend-ignore-re = [
"BUILDing",
"optin=",
"to optin to experiments",
"data.optin;",
"MEDIA-343ded3e",
"SYSTEMtaco",
'"FOO.+"',
"COM--MENT",
"splacementMappletfeDistantLightmlfeFloodfeFuncAfeFuncBfeFuncGfeFuncRfeGaus",
"bang=ba;",
'"bang", "ba"',
"cbt=ewIBRj20LWkIv_Xk97MIENbBkf8DGMDAvHsiFWNsZWFubXltYWMubWFjcGF3LmNvbTIICAUTGO27CBRCF2NhLXB1Yi0yNjQwNDcyNzcyMzY4NjQySAZYN2DsA3ABegUIAxIBCA",
'data-videoid="[^"]"',
'data-shortcode="[^"]+"',
# HTML entity
"&[a-z]+;",
# Known typo
"col-fourty",
# Lorem ipsum
"libero varius",
"facilisi morbi",
"facilisis sed",
"nulla facilisi",
"Nam nec",
"Nam porta",
"Nam dui",
"Nam elementum",
"Nam et magna",
"Nam finibus",
"Nam lacinia",
"Nam molestie",
"Nam pellentesque",
"Nam posuere",
"Nam quam",
"Nam sit amet",
"Nulla facilisi",
"ridiculus mus",
"varius est",
"varius libero",
"varius sem",
"varius suscipit",
"varius vitae",
]
[default.extend-words]
# Brand
"adition" = "adition"
[default.extend-identifiers]
# Typos
"Wordpress" = "WordPress"
"amp_stads" = "amp_stads"
"IS_UTF8_TRAIL_2ND_BYTE_VALID" = "IS_UTF8_TRAIL_2ND_BYTE_VALID"
# TODO typo
"BASE_TAG_MUST_PRECEED_ALL_URLS" = "BASE_TAG_MUST_PRECEED_ALL_URLS"
"ValidationError_BASE_TAG_MUST_PRECEED_ALL_URLS" = "ValidationError_BASE_TAG_MUST_PRECEED_ALL_URLS"
# Is it a typo??
"enqueAction" = "enqueAction" |
erwinmombay
approved these changes
Feb 14, 2024
@powerivq Friendly ping from the past 🏓 |
@szepeviktor You have conflicts needing to be resolved. |
Done 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@powerivq From #39602
See
typos
config in that PR!These three PR-s are all I have for you.
If you are interested in additional ~1000 typos please do run
typos
yourself.