Skip to content

Improve determination of eligible post types for AMP #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2022
Merged

Improve determination of eligible post types for AMP #6897

merged 5 commits into from
Feb 14, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

Summary

Fixes #6883

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh marked this pull request as ready for review February 7, 2022 12:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022 •
edited
Loading

Plugin builds for 73cf912 are ready 🛎️!

@westonruter
Copy link
Member

Would you add a test case for when someone filters is_post_type_viewable to be false?

@maitreyie-chavan maitreyie-chavan added this to the v2.2.2 milestone Feb 9, 2022
@maitreyie-chavan maitreyie-chavan added the Enhancement New feature or improvement of an existing one label Feb 9, 2022
@dhaval-parekh dhaval-parekh force-pushed the enhancement/6883-update-eligible-post-types-for-amp branch from 23d4d48 to cc0631e Compare February 11, 2022 07:10
@dhaval-parekh
Copy link
Collaborator Author

Would you add a test case for when someone filters is_post_type_viewable to be false?

I have added a test case when someone uses the is_post_type_viewable filter to be false.

@westonruter westonruter merged commit 9fa6cbc into develop Feb 14, 2022
@westonruter westonruter deleted the enhancement/6883-update-eligible-post-types-for-amp branch February 14, 2022 19:11
westonruter added a commit that referenced this pull request Feb 14, 2022
@westonruter @dhaval-parekh
Improve determination of eligible post types for AMP (#6897)
3f04746 
Co-authored-by: Dhaval Parekh <[email protected]>
@dhaval-parekh
Copy link
Collaborator Author

dhaval-parekh commented Mar 31, 2022 •
edited
Loading

Steps for QA

  • Install and activate the this plugin.
  • The "Book" and "Car" post types are eligible to post types for AMP. While "Secret", "Secret Book" and "Secret Car" are not eligible.

image

@dhaval-parekh dhaval-parekh mentioned this pull request Mar 31, 2022
Closed
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@milindmore22 milindmore22 Awaiting requested review from milindmore22

@delawski delawski Awaiting requested review from delawski

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

Improve determination of eligible post types for AMP
3 participants
@dhaval-parekh @westonruter @maitreyie-chavan