Skip to content

Update Composer to use AMP toolbox v0.10.0 #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

schlessera
Copy link
Collaborator

@schlessera schlessera commented Jan 7, 2022

Summary

This PR updates the AMP Toolbox dependency to use the release v0.10.0.

It also adds explicit permissions to the Composer file for the required plugins to be run, to avoid Composer warnings introduced with the addition of the allow-plugins configuration setting.

Furthermore, it adapts the linting workflow to allow for the composer-normalize plugin to be run without warnings.

cc/ @swissspidy

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@schlessera schlessera requested a review from westonruter January 7, 2022 19:04
@schlessera schlessera added the dependencies Pull requests that update a dependency file label Jan 7, 2022
@swissspidy
Copy link
Collaborator

You need to run composer normalize

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

Plugin builds for cabb004 are ready 🛎️!

@westonruter westonruter merged commit f8fe694 into develop Jan 10, 2022
@westonruter westonruter deleted the add/update-to-amp-toolbox-0.10.0 branch January 10, 2022 23:56
@westonruter westonruter added this to the v2.3 milestone Jan 10, 2022
@westonruter westonruter modified the milestones: v2.3, v2.2.1 Jan 27, 2022
@delawski
Copy link
Collaborator

QA Passed

Since this is a development-related update, instead of downloading one of the plugin Development Builds, I pulled a fresh copy of the plugin (develop branch).

✅ When I ran composer install command, I got no prompt about adding a plugin to the allowed list. Also, amp-toolbox v0.10.0 has been installed as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants