Fix selection of Reader theme causing validated URLs to always be stale #6779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've selected Reader mode and chose a Reader theme:
Upon doing a Site Scan, the stale message goes away. But after I reload, the stale message appears:
Going to the AMP Validated URLs screen shows that all the just-scanned URLs are stale:
My active theme is
twentyseventeen
and my Reader theme istwentythirteen
, and I can see thatAMP_Validated_URL_Post_Type::get_post_staleness()
is returning unexpectedly:Clearly
\AMP_Validated_URL_Post_Type::get_validated_environment()
is not taking Reader themes into account. This fixes that.Checklist