Improve Sandboxing info in AMP admin bar menu item

[westonruter]

Summary

I realized the AMP admin menu item was not entirely clear when the Sandboxing experiment is enabled. I've improved the tooltip for the number emoji and I've added a submenu item which contains the same text, with a link to the Sandboxing drawer on the Settings screen:

Checklist

• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[github-actions]

Plugin builds for 0bb2081 are ready 🛎️!

• Download development build
• Download production build

[bartoszgadomski]

Could this be reordered?

amp-wp/src/Sandboxing.php

Lines 273 to 277 in 21412aa

	$span = $dom->createElement( Tag::SPAN );
	$amp_link->appendChild( $dom->createTextNode( ' ' ) );
	$span->textContent = $text;
	$span->setAttribute( Attribute::TITLE, $title );
	$amp_link->appendChild( $span );

To something like:

$span = $dom->createElement( Tag::SPAN );
$span->textContent = $text;
$span->setAttribute( Attribute::TITLE, $title );

$amp_link->appendChild( $dom->createTextNode( ' ' ) );
$amp_link->appendChild( $span );

[westonruter]

Yeah, except let's put the setAttribute call before textContent assignment. Then we don't have to align the equals signs 😊

Can you make your change an actual GitHub suggestion?

[bartoszgadomski]

Can you make your change an actual GitHub suggestion?

Looks like you were faster 😁

[bartoszgadomski]

If current user does not have manage_options capabilities, link href attribute will be empty:

• do we want to display "sandboxing level" information to users that does not have rights to manage site options?
• if yes, could this be displayed in <span> element instead of <a>?

[westonruter]

Yeah, I tried a span at first, but the admin bad styles specifically are targeting an a here. It would be very unusual for the admin menu item to be shown if the user can't manage_options anyway, since it's usually bound up with whether a use can do validation. So I'd consider this to just be an edge case.

The sandboxing level is shown in the meta generator tag otherwise, so it's not a problem to show it to users who aren't admins.

Good questions.

[milindmore22]

QA Passed

Seen tooltip with Sandboxing level