Fix stepper icons occasionally not being displayed correctly in Onboarding Wizard #6496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 8182823 are ready 🛎️!
|
westonruter
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with the "check" SVG icon not rendering correctly on the Onboarding Wizard page. This seems to only affect Safari and stems from the SVG icon being repeated multiple times on the page, causing the IDs within the SVG to be repeated as well. The fix for this then would be to use a unique IDs for each instance of the SVG icon on the page.
This CSS-Tricks blog post helped me to debug the issue at hand and I noticed that the Web Stories team also ran into a similar issue in GoogleForCreators/web-stories-wp#8401.
Demo
Before
before.mp4
After
after.mp4
Fixes #6490
Checklist