Skip to content

Always include numbers in strings passed to _n() for SiteHealth #6306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

Always include numbers in strings passed to _n() for SiteHealth #6306

merged 1 commit into from
May 21, 2021

Conversation

westonruter
Copy link
Member

Summary

Fixes #6305

One Undefined Function All Functions Undefined
image image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1.3 milestone May 21, 2021
@westonruter westonruter mentioned this pull request May 21, 2021
Closed
@github-actions
Copy link
Contributor

Plugin builds for 8f1ee7b are ready 🛎️!

@tobifjellner
Copy link

Thanks, @westonruter
The commit looks good from my point of view.

@westonruter westonruter requested a review from pierlon May 21, 2021 17:36
@westonruter westonruter merged commit 4ee5026 into develop May 21, 2021
@westonruter westonruter deleted the fix/translation-function-usage branch May 21, 2021 20:40
westonruter added a commit that referenced this pull request May 21, 2021
@westonruter
Always include numbers in strings passed to _n() for SiteHealth (#…
defd1bd 
…6306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlon pierlon pierlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.3
Development

Successfully merging this pull request may close these issues.

Incorrect use of _n() in /src/admin/site-health.php
3 participants
@westonruter @tobifjellner @pierlon