Skip to content

Show HTTP error code when failing to fetch #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2021

Conversation

westonruter
Copy link
Member

Summary

In a support topic I discovered that the HTTP status code is not revealed when a stylesheet fetch fails. This PR shows the status code and its corresponding message.

Before After
image image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1.2 milestone May 15, 2021
@westonruter westonruter requested a review from pierlon May 15, 2021 18:10
@github-actions
Copy link
Contributor

Plugin builds for b922c0c are ready 🛎️!

@westonruter westonruter merged commit 8e7fe29 into develop May 15, 2021
@westonruter westonruter deleted the add/stylesheet-fetch-error-code branch May 15, 2021 23:30
@westonruter westonruter self-assigned this May 18, 2021
@westonruter
Copy link
Member Author

QA Passed

I added a Custom HTML block that points to a non-existent stylesheet:

image

The details shows the HTTP error code:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants