Skip to content

Hide validation count in menu when on dev tools screen, dev tools is not enabled and Reader mode is enabled #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Apr 27, 2021

Summary

Fixes #6120

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added the WS:Core Work stream for Plugin core label Apr 27, 2021
@pierlon pierlon added this to the v2.1 milestone Apr 27, 2021
@pierlon pierlon requested a review from westonruter April 27, 2021 03:13
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2021

Plugin builds for 8f9fefd are ready 🛎️!

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #6122 (8f9fefd) into develop (f7ad0a8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6122      +/-   ##
=============================================
+ Coverage      75.03%   75.11%   +0.08%     
- Complexity      5829     5847      +18     
=============================================
  Files            232      233       +1     
  Lines          17618    17655      +37     
=============================================
+ Hits           13219    13262      +43     
+ Misses          4399     4393       -6     
Flag Coverage Δ Complexity Δ
javascript 79.84% <ø> (ø) 0.00 <ø> (ø)
php 74.90% <100.00%> (+0.09%) 5847.00 <0.00> (+18.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/DevTools/UserAccess.php 100.00% <ø> (ø) 22.00 <0.00> (ø)
...s/validation/class-amp-validated-url-post-type.php 65.27% <100.00%> (+0.05%) 441.00 <0.00> (+1.00)
...validation/class-amp-validation-error-taxonomy.php 50.23% <100.00%> (+0.06%) 540.00 <0.00> (+1.00)
includes/amp-helper-functions.php 84.93% <0.00%> (ø) 0.00% <0.00%> (ø%)
includes/sanitizers/class-amp-object-sanitizer.php 100.00% <0.00%> (ø) 11.00% <0.00%> (?%)
includes/embeds/class-amp-core-block-handler.php 93.27% <0.00%> (+5.88%) 48.00% <0.00%> (+5.00%)

@westonruter
Copy link
Member

When I turn off DevTools and manually go to /wp-admin/edit.php?post_type=amp_validated_url, before I saw:

image

But in this branch I see:

image

When I turn DevTools back on, I again see:

image

So it's working as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation count assets not enqueued when on any Dev Tools screen and Reader mode is enabled
2 participants