Show error when attempting to validate an AMP-unavailable URL instead of forcing AMP to be available #5296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of forcing AMP to be available
|
|
# Conflicts: # includes/class-amp-theme-support.php
…idating invalid AMP page
Codecov Report
@@ Coverage Diff @@
## develop #5296 +/- ##
==========================================
Coverage 75.39% 75.39%
- Complexity 5700 5706 +6
==========================================
Files 218 218
Lines 17255 17270 +15
==========================================
+ Hits 13009 13021 +12
- Misses 4246 4249 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Plugin builds for 24583ad are ready 🛎️!
|
|
@westonruter Asking for your review as I can't assign you as one 🙂. |
…ating-amp-unavailable-urls * 'develop' of github.com:ampproject/amp-wp: (24 commits) Update DetermineHeroImagesTest to use amp-img instead of img Prevent DetermineHeroImages transformer from targeting any img element Avoid identifying noscript fallback img as hero image candidates Bump eslint-plugin-jest from 24.3.2 to 24.3.4 Bump postcss from 8.2.8 to 8.2.9 Bump svgo from 2.2.2 to 2.3.0 Bump @babel/core from 7.13.10 to 7.13.14 Bump eslint from 7.22.0 to 7.23.0 Bump classnames from 2.2.6 to 2.3.1 Add covers phpdoc tags Fix tests and optimize attribute removal Restore object-fit:contain for a reduced-specificity selector Omit problematic styling attributes from noscript fallback elements Fix inheritance of replaced-content properties on noscript fallbacks Fix double arrow alignment Remove obsolete core sanitizer CSS code from 2019, 2017, and 2014 Inherit replaced-content properties for replaced content shadow elements and noscript fallbacks Remove obsolete object-fit:contain for unknown-sized image since redundant with object-fit=contain attr Bump postcss-import from 14.0.0 to 14.0.1 Restrict object-fit to images which have the .amp-wp-unknown-size class ...
pierlon
approved these changes
Apr 8, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5295
This error is shown now when attempting to validate a URL that is no longer available as AMP:
Checklist