Hide recommendations when Site Scan results are stale

[westonruter]

Feature Description

If the Site Scan results are stale or the Site Scan is currently in progress, none of the Template Modes should have “Recommended” or “Not recommended” appear anywhere. These should only be shown if the Site Scan is complete and the results are not stale.

Additionally, it may make sense to hide the notice above the template modes since the Site Scan box already is indicating "Stale Results":

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

[delawski]

The Template Mode recommendations (both on the AMP Settings screen and in the Wizard) are defined in getTemplateModeRecommendation() and that's where the logic needs to be updated. However, since the descriptions and the recommendation levels are based on the matrix in the Template Mode Selection doc, it's worth first updating the matrix and use it as a single source of truth.

The notice about the results being stale it not related to getTemplateModeRecommendation() and should be removed separately.

[dhaval-parekh]

✅ Remove notice about stale scan results from the Template Mode section on the AMP Settings screen.

✅ Do not show any recommendations when the scan results are stale.

⚠️ Do not show any recommendations when a scan is in progress.
When results are not stale but the user still rescans the site. recommendations are still displayed to the user

AMP-GH-6690.mov

[westonruter]

⚠️ Do not show any recommendations when a scan is in progress.
When results are not stale but the user still rescans the site. recommendations are still displayed to the user

If the results are not stale, I don't think an in-progress scan should necessarily hide the recommendations. If the results are stale then certainly the recommendations should be hidden, both before and during a scan. @delawski Isn't that right?

[dhaval-parekh]

If the results are not stale, I don't think an in-progress scan should necessarily hide the recommendations.

I agree with that.

If the results are stale then certainly the recommendations should be hidden, both before and during a scan.

Yes, It is hidden when results are stale and during the scan (if results are stale).

With that can mark this issue as QA Passed.

[delawski]

If the results are not stale, I don't think an in-progress scan should necessarily hide the recommendations. If the results are stale then certainly the recommendations should be hidden, both before and during a scan. @delawski Isn't that right?

That is correct 👍