Skip to content

Check hero image media attribute before srcset #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2021
Merged

Check hero image media attribute before srcset #136

merged 6 commits into from
Apr 9, 2021

Conversation

schlessera
Copy link
Collaborator

This PR moves the media attribute check further up to avoid throwing an error for a hero image that was not meant to receive a preload anyway.

@schlessera schlessera added Bug Something isn't working Optimizer labels Apr 8, 2021
@schlessera schlessera added this to the 0.4.0 milestone Apr 8, 2021
@schlessera schlessera requested a review from westonruter April 8, 2021 16:47
@westonruter
Copy link
Member

Comment is removed as expected:

Before After
image image

@schlessera schlessera merged commit fe02ccc into main Apr 9, 2021
@schlessera schlessera deleted the fix/check-hero-image-media-before-srcset branch April 9, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Optimizer
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@schlessera @westonruter