Skip to content

Remove hard-coded isTiny() result for intrinsic layout #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Remove hard-coded isTiny() result for intrinsic layout #115

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2660462
Remove hard-coded isTiny() result for intrinsic layout
schlessera Mar 29, 2021
c00fa7e
Adapt test
schlessera Mar 29, 2021
83f8805
Skip spec test until fixed in JS package
schlessera Mar 29, 2021
cd4d703
Reenable skipped test after spec suite update
schlessera Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Optimizer/ImageDimensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ public function isTiny($threshold = self::TINY_THRESHOLD)
}

switch ($this->getLayout()) {
// For 'intrinsic' layout, the natural dimensions are more important, so assume not tiny for now.
case Layout::INTRINSIC:
// For 'responsive' layout, the image adapts to the container and can grow beyond its dimensions.
case Layout::RESPONSIVE:
return false;
Expand Down