Skip to content

refactor: remove reflection on unit tests #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

refactor: remove reflection on unit tests #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc5de26
move tests to kotlin package
polbins Apr 8, 2025
585271b
use FakeAmplitude for core tests
polbins Apr 8, 2025
2e492d9
add FakeAndroidAmplitude and use that instead of using reflection for…
polbins Apr 9, 2025
1da1230
remove lateinit var property and just use local val
polbins Apr 10, 2025
8ddb1fe
cleanup tests, fix usage of stub vs. fake
polbins Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions android/src/main/java/com/amplitude/android/Amplitude.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,37 @@ import com.amplitude.android.plugins.AndroidLifecyclePlugin
import com.amplitude.android.plugins.AndroidNetworkConnectivityCheckerPlugin
import com.amplitude.android.storage.AndroidStorageContextV3
import com.amplitude.android.utilities.ActivityLifecycleObserver
import com.amplitude.core.Amplitude
import com.amplitude.core.State
import com.amplitude.core.events.BaseEvent
import com.amplitude.core.platform.plugins.AmplitudeDestination
import com.amplitude.core.platform.plugins.GetAmpliExtrasPlugin
import com.amplitude.id.IdentityConfiguration
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Deferred
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.asCoroutineDispatcher
import kotlinx.coroutines.launch
import java.util.concurrent.Executors
import com.amplitude.core.Amplitude as CoreAmplitude

open class Amplitude internal constructor(
configuration: Configuration,
state: State,
amplitudeScope: CoroutineScope = CoroutineScope(SupervisorJob()),
amplitudeDispatcher: CoroutineDispatcher = Executors.newCachedThreadPool().asCoroutineDispatcher(),
networkIODispatcher: CoroutineDispatcher = Executors.newSingleThreadExecutor().asCoroutineDispatcher(),
storageIODispatcher: CoroutineDispatcher = Executors.newSingleThreadExecutor().asCoroutineDispatcher()
) : CoreAmplitude(
configuration = configuration,
store = state,
amplitudeScope = amplitudeScope,
amplitudeDispatcher = amplitudeDispatcher,
networkIODispatcher = networkIODispatcher,
storageIODispatcher = storageIODispatcher
) {
constructor(configuration: Configuration) : this(configuration, State())

open class Amplitude(
configuration: Configuration
) : Amplitude(configuration) {
private lateinit var androidContextPlugin: AndroidContextPlugin

val sessionId: Long
Expand Down
Loading