fix: remove synchronized on mediator #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polbins
force-pushed
the
AMP-124676/remove-synchronized-on-mediator
branch
from
31d9386 to
6e802ae
Compare
igor-amp
requested changes
Mar 13, 2025
polbins
force-pushed
the
AMP-124676/remove-synchronized-on-mediator
branch
from
6e802ae to
a0294eb
Compare
igor-amp
requested changes
Mar 13, 2025
core/src/test/kotlin/com/amplitude/core/platform/MediatorTest.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/com/amplitude/core/platform/MediatorTest.kt
Outdated
Show resolved
Hide resolved
polbins
force-pushed
the
AMP-124676/remove-synchronized-on-mediator
branch
from
97d02c3 to
04aeba8
Compare
igor-amp
approved these changes
Mar 14, 2025
|
🎉 This PR is included in version 1.20.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
synchronizedblocks onMediatorin favor ofCopyOnWriteArrayListinstead.It would be good to review this PR on a per commit basis.
Checklist