fix: respect play services flags inside context provider #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
AMP-125514/cleanup-prior-to-context-provider-changes
to
main
March 6, 2025 21:38
igor-amp
reviewed
Mar 6, 2025
common-android/src/main/java/com/amplitude/common/android/AndroidContextProvider.kt
Outdated
Show resolved
Hide resolved
- this should now respect the value set from tracking options
polbins
force-pushed
the
AMP-125514/respect-play-services-flags-context-provider
branch
from
2850d20 to
a3b8335
Compare
igor-amp
approved these changes
Mar 7, 2025
polbins
deleted the
AMP-125514/respect-play-services-flags-context-provider
branch
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
## [1.20.3](v1.20.2...v1.20.3) (2025-03-10) ### Bug Fixes * add consumer-rules for useAppSetIdForDeviceId = true ([#249](#249)) ([83cc361](83cc361)) * ignore illegal state exception on addShutdownHook w/c happens when shutdown sequence has begun ([#248](#248)) ([864cbc4](864cbc4)) * initialize custom http client with configuration ([#240](#240)) ([1173728](1173728)) * respect play services flags inside context provider ([#252](#252)) ([e7f9112](e7f9112))
|
🎉 This PR is included in version 1.20.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
shouldTrackAppSetIdto context provider, this respects the value set from tracking options.Checklist