Ameba + formatting #13
Conversation
|
@Sija @drujensen @robacarp This is ready for review as well. Prob could also do a release after this. For the route constrains and optional segments. |
There was a problem hiding this comment.
@Blacksmoke16 thanks! It's good to get this in place. One small comment but it's not a blocker.
| path[0..optional_start].each do |segment| | ||
| carat_position += segment.size | ||
| path[0..optional_start].each do |s| | ||
| carat_position += s.size |
There was a problem hiding this comment.
This is the only change that I don't care for...what's the benefit to switching these to single letter names?
There was a problem hiding this comment.
It was due to an ameba failure that it was shadowing the var segment higher in the file.
There was a problem hiding this comment.
Hm. I think ameba and I disagree about that -- segment on line 121 is declared and used inside the loop. Oh well, I guess.
There was a problem hiding this comment.
I have a problem with that rule too, maybe we could disable it globally in .ameba.yml?
There was a problem hiding this comment.
Btw, this could be rewritten to carat_position += path[0..optional_start].sum(&.size)
No description provided.