Skip to content

Adds TypeRefWalker to support type reference resolution #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

popematt
Copy link
Contributor

Issue #, if available:

#228

Description of changes:

  • Creates a resolver module
  • Moves SchemaStore to the resolver module
  • Moves/refactors HasTypeReferences into TypeRefVisitor and TypeRefWalker
  • Add TypeRefWalker implementations for the whole model
  • Updates a few builder methods that had ugly signatures—e.g. they were using a specific type Something instead of T: Into<Something>.
  • Minor fix in violation_recorder.rs to get cargo doc to stop complaining about unclosed HTML tags.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from zslayton March 31, 2025 15:54
@popematt popematt merged commit cae9e1d into amazon-ion:dev-1.0.0 Mar 31, 2025
3 checks passed
@popematt popematt deleted the type-ref-visitor branch March 31, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants