Adds Bag type #240
Merged
Adds Bag type #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Mar 18, 2025
| /// and unsupported. Any modifications should be done by trivially converting to a `Vec`, applying | ||
| /// the modifications, and then converting back to a `Bag`. | ||
| /// | ||
| /// TODO: Replace the vec with a HashBag or come up with a less hacky way to sort the type arguments. |
There was a problem hiding this comment.
Not really. I'd like to come up with a less naive approach because using Debug as the sort key works by coincidence rather than by design.
Co-authored-by: Zack Slayton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#228
Suggested in #238 (comment)
Description of changes:
Adds a naive
Bagimplementation and switchesValidValues,AnyOf,OneOf,AllOf, andTypeDefinitionto use rather than having them all sort their ownVecor have incorrect equality.I tried to minimize the diff as best as I could. The interesting changes are entirely in
bag.rs. The rest of the changes are switchingvec->bag, updating related comments, and updating some constructor signatures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.