Skip to content

Expose owned sequence iterator; Add Owned Field iterator. #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Dec 3, 2024

Follow-up to #858

This PR includes a couple changes intended to make working with owned Elements easier and not require cloning for 'projecting' an element to be replaced by something it contains.

  • Exposes ConversionOperationError and ConversionOperationResult
  • Adds ability to retrieve original value from ConversionOperationError via original_value()
  • Adds OwnedFieldIterator for iterating struct fields of owned Structs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr force-pushed the feat-owned-conversion-qol branch from 0fe5a20 to b7841d3 Compare December 3, 2024 03:17
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.84%. Comparing base (f3b6cca) to head (dfcc720).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/result/conversion.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   77.83%   77.84%   +0.01%     
==========================================
  Files         136      136              
  Lines       34205    34235      +30     
  Branches    34205    34235      +30     
==========================================
+ Hits        26623    26650      +27     
- Misses       5626     5629       +3     
  Partials     1956     1956              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr force-pushed the feat-owned-conversion-qol branch 3 times, most recently from 2c7d9fd to a5b4123 Compare December 3, 2024 05:07
@jpschorr jpschorr force-pushed the feat-owned-conversion-qol branch from a5b4123 to f62eb2e Compare December 3, 2024 05:16
@jpschorr jpschorr marked this pull request as ready for review December 3, 2024 18:07
@zslayton zslayton merged commit 1aaa40e into main Dec 3, 2024
23 of 31 checks passed
@zslayton zslayton deleted the feat-owned-conversion-qol branch December 3, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants