Edition 2021 and version bumps #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the Rust edition of: * ion-rs * ion-hash * ion-c-sys-macros * ion-c-sys from 2018 to 2021. No code changes were required. This patch also bumps their respective versions.
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
==========================================
+ Coverage 91.44% 91.49% +0.04%
==========================================
Files 67 67
Lines 10324 10298 -26
==========================================
- Hits 9441 9422 -19
+ Misses 883 876 -7
Continue to review full report at Codecov.
|
zslayton
commented
Jan 10, 2022
| @@ -16,8 +16,8 @@ exclude = [ | |||
| "**/ion-tests/iontestdata/**", | |||
| "*.pdf" | |||
| ] | |||
| version = "0.7.0" | |||
| edition = "2018" | |||
| version = "0.8.0" | |||
There was a problem hiding this comment.
ion-hash, ion-c-sys, and ion-c-sys-macros have not been modified since their last change. The edition bump doesn't affect their APIs, so I've bumped their patch version (The z in x.y.z).
In contrast, ion-rs has landed some substantive changes since v0.7.0 (for example: the SystemReader in #344), so it's getting a minor version bump to v0.8.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Rust edition of:
from
2018to2021. No code changes were required.The GitHub Action that generates a code coverage report uses a pinned nightly version of
rustcfrom August 2021, just before edition 2021 was stabilized. I've bumped it to the latest nightly so it can build the new edition.This patch also bumps the version of each crate.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.