-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/reward multiwallet #1
base: main
Are you sure you want to change the base?
Conversation
- Any arbritrary number of wallets can be created to receive miner reward - Preexisting custom_signet is still rewarded - A new script "setup-mineto-address.sh" is added which got major logic for this update
@Rajil1213 Are we planning to connect all the bridge nodes to the same bitcoin node, which is also the miner node of the signet? I dont think this is a good idea. |
@sapinb that's not a requirement. Each bridge node needs two wallets:
We are planning to deploy 3 bridge nodes. So that means we need 3 well-funded addresses and 3 addresses with 1 BTC. These addresses will be derived from some master xpriv during bridge deployment. |
@Rajil1213 Got it. So can I modify the program such that it takes some addresses (bridge nodes) and mining rewards are sent to them in cycle instead of managing arbritrary wallets for them? |
Yes. That's the most straightforward approach. These wallets don't need a lot of funds either. One wallet only ever needs 1 BTC. The other wallet needs a constant influx of funds but even with just 4 BTC, it can serve ~10000 deposits/withdrawals (not considering the transaction fees). Another thing to note is that for the first deployment we also require the miner node to be run with the following options:
This will allow transactions with 0 fees to be mined as well since we are not handling any dynamic fees during our first deployment of the bridge. |
This pr enable two important features:
The no of wallets is controlled by NUM_WALLETS env, if its 0 then node will only have custom_signet wallet.