Skip to content

a silly mistake in conditional check in cd corrected #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/cd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ jobs:

- name: Update Docker image tag in Helm values
env:
SERVICE: ${{ matrix.service }}
SHORT_TAG: ${{ github.sha }}
CLUSTER_NAME: ${{ vars.CLUSTER_NAME }}
run: |
Expand All @@ -127,12 +126,12 @@ jobs:

if [[ "${{ needs.detect-changes.outputs.frontend_changed }}" == "true" ]]; then
yq eval -i ".batchExpFe.image.tag = \"$SHORT_TAG\"" $VALUES_FILE
elif [["${{ needs.detect-changes.outputs.backend_changed }}" == "true" ]]; then
fi
if [["${{ needs.detect-changes.outputs.backend_changed }}" == "true" ]]; then
yq eval -i ".batchExpBe.image.tag = \"$SHORT_TAG\"" $VALUES_FILE
fi
- name: Commit and push changes
env:
SERVICE: ${{ matrix.service }}
SHORT_TAG: ${{ github.sha }}
GH_ACTIONS_USER_NAME: ${{ vars.GH_ACTIONS_USER_NAME }}
CLUSTER_NAME: ${{ vars.CLUSTER_NAME }}
Expand All @@ -147,7 +146,7 @@ jobs:
echo "No changes to commit."
else
git add clusters/$CLUSTER_NAME/values
git commit -m "Update $SERVICE image tag to $SHORT_TAG"
git commit -m "Update image tags to $SHORT_TAG for updated services"
git pull --rebase origin $BRANCH_OF_DEPLOYMENT_REPO
git push origin $BRANCH_OF_DEPLOYMENT_REPO
fi
3 changes: 2 additions & 1 deletion backend/database/src/services/checkpoint_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ impl<'a> CheckpointService<'a> {
pub fn new(db: &'a DatabaseConnection) -> Self {
Self { db }
}

pub async fn checkpoint_exists(&self, idx: i64) -> bool {
Checkpoint::find()
.filter(model::checkpoint::Column::Idx.eq(idx))
Expand All @@ -24,6 +24,7 @@ impl<'a> CheckpointService<'a> {
.map(|result| result.is_some())
.unwrap_or(false)
}

/// Insert a new checkpoint into the database
pub async fn insert_checkpoint(&self, checkpoint: RpcCheckpointInfo) {
let idx: i64 = PgU64(checkpoint.idx).to_i64();
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/Table/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import TableBody from "./TableBody";
interface TableProps {
data: RpcCheckpointInfoBatchExp[],
}

const Table: React.FC<TableProps> = ({ }) => {
return (
<>
Expand Down