Skip to content

Fix images and videos scaling #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

Fix images and videos scaling #169

merged 2 commits into from
May 6, 2025

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented May 6, 2025

fixes #117

@epszaw
fix image and video attachments width
326e48d 
rework modal component header
@epszaw epszaw requested review from delatrie and todti May 6, 2025 08:48
delatrie
delatrie reviewed May 6, 2025
View reviewed changes
Copy link
Collaborator

@delatrie delatrie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with the video:

yarn workspace sandbox run allure awesome ../reader/test/resources/xcresultdata/activities/videoCapture.xcresult

It hides the controls below:

Screen.Recording.2025-05-06.at.16.15.22.mov

@epszaw epszaw merged commit b28b43a into main May 6, 2025
5 checks passed
@epszaw epszaw deleted the fix-images-and-videos-scaling branch May 6, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delatrie delatrie delatrie approved these changes

@todti todti Awaiting requested review from todti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Awesome: images and videos are not scaled down when rendered in the test body
2 participants
@epszaw @delatrie