chore(rpc-types-mev): improve bundle API flexibility #2583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for
EthSendBundle
,EthBundleHash
and removal ofSendBundleResponse
:bundle_hash
inEthBundleHash
is optional. Not all builders return such a bundle hashSendBundleResponse
in favor ofEthBundleHash
extra_fields
as known fromChainConfig
allow the user to add builder specific fieldsAgain a breaking change, but I have the feeling that it is worth it, for a better usability.
Update: Initially I replaced
Vec
withHashSet
for fields likereverting_tx_hashes
, but this would potentially lead to a non-deterministic bundle hash calculation. I reverted this change.