Skip to content

chore(rpc-types-mev): improve bundle API flexibility #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 15, 2025

Conversation

cakevm
Copy link
Contributor

@cakevm cakevm commented Jun 15, 2025

Changes for EthSendBundle, EthBundleHash and removal of SendBundleResponse:

  • bundle_hash in EthBundleHash is optional. Not all builders return such a bundle hash
  • Remove duplicate struct SendBundleResponse in favor of EthBundleHash
  • New extra_fields as known from ChainConfig allow the user to add builder specific fields

Again a breaking change, but I have the feeling that it is worth it, for a better usability.

Update: Initially I replaced Vec with HashSet for fields like reverting_tx_hashes, but this would potentially lead to a non-deterministic bundle hash calculation. I reverted this change.

@cakevm cakevm changed the title chore: Add option for extra fields for send bundle and use a set instead of a list chore(rpc-types-mev): improve bundle API usability and flexibility Jun 15, 2025
@cakevm cakevm changed the title chore(rpc-types-mev): improve bundle API usability and flexibility chore(rpc-types-mev): improve bundle API flexibility Jun 15, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Alloy Jun 15, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Reviewed in Alloy Jun 15, 2025
@cakevm
Copy link
Contributor Author

cakevm commented Jun 15, 2025

I’m not sure, but Clippy used to complain whenever I added #[deprecated] to the struct. I believe the type mapping will achieve the same goal :)

@mattsse mattsse merged commit 28eccbb into alloy-rs:main Jun 15, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy Jun 15, 2025
@cakevm cakevm deleted the improve-bundle-struct branch June 15, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants