feat(json-rpc): add request extensions #2535
Merged
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
requested review from
DaniPopes,
mattsse,
klkvr and
yash-atreya
as code owners
mattsse
requested changes
May 31, 2025
crates/json-rpc/src/request.rs
Outdated
| pub struct RequestMeta { | ||
| /// The method name. | ||
| pub method: Cow<'static, str>, | ||
| /// The request ID. | ||
| pub id: Id, | ||
| /// Whether the request is a subscription, other than `eth_subscribe`. | ||
| is_subscription: bool, | ||
| /// Optional HTTP extensions for the request. |
There was a problem hiding this comment.
I think the docs here are a bit misleading, while this is a type from the http crate, this doesnt have anything to do with http really, can we add a note to this here and the setter+getter that this can be used to store extradata.
There was a problem hiding this comment.
Done in 2b44c1a
mattsse
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Diving into alloy json-rpc I found that the Tower traits are all implemented for the type
RequestPacket.One big difference that I can see with the regular
http::Requestis the lack of http extensions which can be nice to write custom layers that use request-specific metadata.One example use case would be a custom redundancy layer (e.g. as an expansion to
FallbackService) that allows per-request redundancy criteria, for instance to require consensus between N transports, or to use the "highest value" returned by N transports.Solution
I've added an optional
extensionsfield to theRequestMetainside each request packet.It should be enough for any Tower layer to query this to define its extra behavior.