Skip to content

feat: Introducing BlockOverrides support to EthCallParams #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 23, 2025
Merged

feat: Introducing BlockOverrides support to EthCallParams #2493

merged 9 commits into from
May 23, 2025

Conversation

Ayushdubey86
Copy link
Contributor

@Ayushdubey86 Ayushdubey86 commented May 22, 2025 •
edited
Loading

mattsse
mattsse requested changes May 22, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this to In Progress in Alloy May 22, 2025
@Ayushdubey86
Copy link
Contributor Author

@mattsse pushed all ! 💯

@Ayushdubey86 Ayushdubey86 requested a review from mattsse May 22, 2025 18:35
mattsse
mattsse requested changes May 22, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last smol nit

crates/provider/src/provider/eth_call/params.rs

let mut seq = serializer.serialize_seq(Some(len))?;
seq.serialize_element(&self.data())?;

if let Some(overrides) = self.overrides() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this but convert this into an else if and add an initial if let some(blockoverrides) first, same pattern as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed

@Ayushdubey86 Ayushdubey86 requested a review from mattsse May 22, 2025 20:49
@github-project-automation github-project-automation bot moved this from In Progress to Reviewed in Alloy May 23, 2025
@mattsse mattsse merged commit 1159501 into alloy-rs:main May 23, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy May 23, 2025
jgomez360 pushed a commit to jgomez360/alloy that referenced this pull request Jun 15, 2025
@Ayushdubey86 @jgomez360
feat: Introducing BlockOverrides support to EthCallParams (alloy-rs#2493
666f6eb 
)

* feat: Introducing BlockOverrides support to EthCallParams

* correct serialization order for block, state and blockOverrides

* json none for empty case

* fixing tc indireclty

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add BlockOverrides support to EthCallParams
2 participants
@Ayushdubey86 @mattsse