feat: add bincode compat for receipt envelope #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
changed the title
shekhirin
approved these changes
Mar 25, 2025
|
@mattsse curious what the philosophy is behind making a new compatible type vs. just making the original type compatible? Also thanks for the fast turn-around! |
this does not work if we want this type to also be embedded in the rpc types which may require things like flatten |
rkrasiuk
pushed a commit
that referenced
this pull request
Mar 31, 2025
* fix: use unwrap_or_else for subscribe * feat: add bincode to receipt * feat: receipt envelope bincode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2242
one more bincode helper type -.-