chore(deps): c-kzg 2.0 #2240
Merged
chore(deps): c-kzg 2.0 #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
commented
Mar 24, 2025
yash-atreya
commented
Mar 24, 2025
yash-atreya
commented
Mar 25, 2025
mattsse
approved these changes
Mar 25, 2025
| DEFAULT.get_or_init(|| alloc::boxed::Box::new(load())) | ||
| } | ||
| } | ||
| Self::Default => c_kzg::ethereum_kzg_settings(0), |
There was a problem hiding this comment.
this ckzg api is incredibly weird, because this allows providing an argument which is then ignored the second time this function is called because the kzgsettings are cached.
however, for this crate this is perfectly fine
yash-atreya
added
blocked
DaniPopes
reviewed
Mar 25, 2025
|
@yash-atreya why is this marked as blocked? I'm wondering if there is an issue with integration |
|
no issue with the integration, but this is a breaking change and would further split crate compatibility until everything is migrated properly. but I think we can now send 0.13 but this must be timed with revm release otherwise this can't be upgraded |
DaniPopes
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1745
Solution
PR Checklist