chore(provider): use WeakClient in GetSubscription
#2219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Mar 19, 2025
yash-atreya
changed the title
provider): apply GetSubscription to traitprovider): use WeakClient in GetSubscription
3 tasks
DaniPopes
reviewed
Mar 20, 2025
|
|
||
| fn into_future(self) -> Self::IntoFuture { | ||
| Box::pin(async move { | ||
| let pubsub = self.root.pubsub_frontend()?; | ||
| let client = | ||
| self.client.upgrade().ok_or(TransportErrorKind::custom_str("client dropped"))?; |
There was a problem hiding this comment.
Isn't ok_or cleaner?
Regarless, it's a nit 5a8d29f
DaniPopes
requested changes
Mar 20, 2025
DaniPopes
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
GetSubscriptionfuture type was introduced in #2203Remove it's reliance on
N: Networkby usingWeakClientSolution
N: Networkgeneric fromGetSubscriptionby usingWeakClientPR Checklist