feat: impl Encodable / Decodable for Receipts #1752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
Rjected
force-pushed
the
impl-encodable-decodable-for-receipts
branch
from
d02f88e to
6538899
Compare
mattsse
reviewed
Dec 4, 2024
Comment on lines
+187
to
+201
| impl<T: Encodable> Encodable for Receipts<T> { | ||
| fn encode(&self, out: &mut dyn BufMut) { | ||
| self.receipt_vec.encode(out) | ||
| } | ||
|
|
||
| fn length(&self) -> usize { | ||
| self.receipt_vec.length() | ||
| } | ||
| } | ||
|
|
||
| impl<T: Decodable> Decodable for Receipts<T> { | ||
| fn decode(buf: &mut &[u8]) -> alloy_rlp::Result<Self> { | ||
| Ok(Self { receipt_vec: Decodable::decode(buf)? }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Yes this should mimic the rlpx format. I'm not sure how we can derive them, because it's a struct and not a newtype, we can't use RlpEncodableWrapper etc. If we derive RlpEncodable, it will insert an additional header which isn't correct.
There was a problem hiding this comment.
ah because RlpEncodableWrapper only works with unnamed and can't handle a single field?
mattsse
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
Deref/DerefMutderives were kind of an antipattern, giving the illusion thatEncodablewas implemented, when it was only due to deref coercion. Decodable was also not implemented. This is required if we ever want to use theReceiptstype in reth.Solution
This instead this removes the derived derefs, and directly implements the encodable / decodable traits.
PR Checklist