Add a verifier to check if generated Dockerfiles are up-to-date. #262
Conversation
|
|
||
| val verifyDockerfileOnBuild: SettingKey[Boolean] = Def.settingKey[Boolean]( | ||
| "If true, `dockerBuild` will depend on `verifyDockerfile`, and will not build if the " + | ||
| "Dockerfile is not up-to-date. Defaults to false." |
There was a problem hiding this comment.
Why default to false? It seems like this is generally the desired behavior, given how easy it is to fall out of sync.
There was a problem hiding this comment.
I think it's more correct to have this as a CI check, not a build-time check. I think it'll cause a lot of annoyances if it's happening on all builds.
Having a warning on all builds by default is good, but I was getting lazy and didn't want to add a third option . . .
There was a problem hiding this comment.
That makes sense. I think the warning would be a nice-to-have, but I wouldn't block this on it. 👍
There was a problem hiding this comment.
OK! I'm adding, it's fairly easy.
There was a problem hiding this comment.
I take that back - it's easy, but not very useful, since the warning gets swallowed in the rest of the build output.
I think forcing this to error is probably a better solution.
This is slightly more complicated than I'd like, due to some code duplication. Due to how sbt handles task dependencies, I don't think there's a cleaner way.