Skip to content

Fix: relation endpoint deletion #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: relation endpoint deletion #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ui/src/context/AnnotationStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,16 @@ export interface TokenId {
export class RelationGroup {
constructor(public sourceIds: string[], public targetIds: string[], public label: Label) {}

// Delete a relation if it is no longer defined due to deleted source/target annotations
updateForAnnotationDeletion(a: Annotation): RelationGroup | undefined {
const sourceEmpty = this.sourceIds.length === 0;
const targetEmpty = this.targetIds.length === 0;

const newSourceIds = this.sourceIds.filter((id) => id !== a.id);
const newTargetIds = this.targetIds.filter((id) => id !== a.id);

const nowSourceEmpty = this.sourceIds.length === 0;
const nowTargetEmpty = this.targetIds.length === 0;
const nowSourceEmpty = newSourceIds.length === 0;
const nowTargetEmpty = newTargetIds.length === 0;

// Only target had any annotations, now it has none,
// so delete.
Expand Down