This repository was archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add custom_dummy_tokens
to PretrainedTransformerTokenizer
#5608
Merged
dirkgr
merged 7 commits into
allenai:main
from
tarohi24:add_args_to_pretrained_tokenizer
Apr 8, 2022
Merged
Add custom_dummy_tokens
to PretrainedTransformerTokenizer
#5608
dirkgr
merged 7 commits into
allenai:main
from
tarohi24:add_args_to_pretrained_tokenizer
Apr 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit aims to fix allenai#5597
epwalsh
suggested changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tarohi24! This looks good, I just have two small suggestions
Co-authored-by: Pete <[email protected]>
Co-authored-by: Pete <[email protected]>
Thanks, @epwalsh for reviewing! The suggestions look good to me. I made commits to reflect these suggestions. |
epwalsh
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @tarohi24!
Looks like we'll need to resolve #5613 before merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to support #5597
Changes proposed in this pull request:
custom_dummy_tokens
argument toPretrainedTransformerTokenizer
. Without that argument, initializingPretrainedTransformerTokenizer
of some non-English models fail.Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.