Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

pin cached-path tighter, make sure our cached-path wrapper still returns str #5587

Merged
merged 3 commits into from
Mar 9, 2022
Merged

pin cached-path tighter, make sure our cached-path wrapper still returns str #5587

merged 3 commits into from
Mar 9, 2022

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Mar 9, 2022 •
edited
Loading

Fixes #5585

Changes proposed:

  • Adds a tighter pin on cached-path to catch breaking changes in the future.
  • Makes sure our cached_path() wrapper still returns a str.
  • Also pins docspec which is needed to build the docs.

See also #5586.

@epwalsh epwalsh requested a review from AkshitaB March 9, 2022 02:51
@epwalsh epwalsh requested a review from dirkgr March 9, 2022 03:04
@epwalsh epwalsh merged commit 3547bfb into main Mar 9, 2022
@epwalsh epwalsh deleted the tighter-pin-on-cached-path branch March 9, 2022 18:28
@epwalsh epwalsh mentioned this pull request Mar 9, 2022
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkgr dirkgr dirkgr approved these changes

@AkshitaB AkshitaB Awaiting requested review from AkshitaB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to load predictor using from_path with cached_path version 1.1.0
2 participants
@epwalsh @dirkgr