Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Add "sub_module" argument in PretrainedTransformerMismatchedEmbedder #5580

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

sythello
Copy link
Contributor

Fixes this question: https://stackoverflow.com/questions/71167641/in-allennlp-how-can-we-set-sub-module-argument-in-pretrainedtransformermismat

Changes proposed in this pull request:

  • Added "sub_module" argument in PretrainedTransformerMismatchedEmbedder initializer.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@dirkgr dirkgr self-assigned this Feb 28, 2022
@dirkgr dirkgr enabled auto-merge (squash) February 28, 2022 18:37
@dirkgr
Copy link
Member

dirkgr commented Feb 28, 2022

Thanks for doing this! Can you add a Changelog entry?

auto-merge was automatically disabled February 28, 2022 18:45

Head branch was pushed to by a user without write access

@sythello
Copy link
Contributor Author

Hi, thank you for the quick response! I have added an entry in CHANGELOG.md, please check.

@dirkgr dirkgr merged commit 9f03803 into allenai:main Feb 28, 2022
@dirkgr
Copy link
Member

dirkgr commented Feb 28, 2022

Fantastic!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants