This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Removes stuff that now lives in the tango repo #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
changed the title
This was referenced Dec 1, 2021
|
Does that mean that tango is going to become a separate package as well? |
|
Resp. that allennlp will depend on it? Because then I could already try starting to package it for conda-forge (and not only when allennlp 2.9.0 rolls around) |
|
Already is: https://github.com/allenai/tango It should be significantly easier to package, since it's new, small, and has few dependencies so far. I would love it if you could take that on. |
|
It's not clear yet that AllenNLP itself has to depend on Tango, but we might go there. allennlp-models definitely does though. |
# Conflicts: # allennlp/common/file_utils.py # allennlp/common/sqlite_sparse_sequence.py
Co-authored-by: Pete <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Tango lives at https://github.com/allenai/tango, we don't need a copy of the codebase here.