This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Add scaling to tqdm bar when downloading files #5397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Rationale:
Seeing million-like numbers in the tqdm bar when downloading large files is quite non-informative. I think that scaled units will be way more useful, as we see them daily while downloading files in the browser of checking connectivity speed on speedtest. Fortunately, tqdm has scaling features that convert numbers to their scaled variants like 12304556B -> 12,3MB.
That is used in other libraries, which deal with pretrained models, for example huggingface/transformers.
Before submitting
section of the
CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.