This repository was archived by the owner on Dec 16, 2022. It is now read-only.
only run CHANGELOG check when source files are modified #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshitaB
approved these changes
Jun 25, 2021
dirkgr
approved these changes
Jun 25, 2021
dirkgr
reviewed
Jun 25, 2021
| - name: Check that CHANGELOG has been updated | ||
| if: env.source_files_changed == 'true' |
There was a problem hiding this comment.
I would have hoped that you can put more complicated expressions here, but I guess not?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so the "Check that CHANGELOG has been updated" CI step will only run when source files (files matching
allennlp/*.py) have been modified. This should result in a cleaner looking CI history for pull requests.