This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Fix W&B callback for distributed training #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
approved these changes
May 25, 2021
| if self._watch_model: | ||
| self.wandb.watch(self.trainer.model) # type: ignore[union-attr] | ||
| self.wandb.watch(self.trainer.model) # type: ignore |
There was a problem hiding this comment.
Is this about Item "None" of "Optional[Something]" has no attribute "watch"? I have been fixing that with assert self.wandb is not None.
There was a problem hiding this comment.
It's because MyPy sees it as undefined, not Optional.
|
|
||
| import wandb | ||
|
|
||
| self.wandb = wandb |
There was a problem hiding this comment.
There is no wandb object? wandb is always global? What if two systems want to use it at the same time?
There was a problem hiding this comment.
Importing wandb may have side effects since at some point it spawns its own background worker(s).
There was a problem hiding this comment.
That is some unfortunate API design.
|
|
||
| self.wandb = wandb | ||
| self.wandb.init( | ||
| self._wandb_kwargs: Dict[str, Any] = dict( |
There was a problem hiding this comment.
Nothing wrong with this, just dict(...) is kind of an unusual way of writing {...}.
Abhishek-P
pushed a commit
to Abhishek-P/allennlp
that referenced
this pull request
Aug 11, 2021
* fix wandb callback for distributed training * fix * close out Co-authored-by: Dirk Groeneveld <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was totally broken for distributed training 🤦♂️