Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

ensure nightly builds don't run for forks #4240

Merged
merged 1 commit into from
May 14, 2020
Merged

ensure nightly builds don't run for forks #4240

merged 1 commit into from
May 14, 2020

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented May 14, 2020

closes #4239

@epwalsh epwalsh mentioned this pull request May 14, 2020
Closed
@epwalsh
Copy link
Member Author

epwalsh commented May 14, 2020

I wish there were a way to specify that the schedule event should only trigger runs on the main repo, but this currently isn't possible, so we have to throw in a check for each individual job in the workflow.

@epwalsh epwalsh requested review from schmmd and dirkgr May 14, 2020 17:13
schmmd
schmmd approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@schmmd schmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck!

@epwalsh epwalsh merged commit 99bf1ff into allenai:master May 14, 2020
@epwalsh epwalsh deleted the no-nightly-builds-for-forks branch May 14, 2020 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmmd schmmd schmmd approved these changes

@dirkgr dirkgr Awaiting requested review from dirkgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Master workflow is running on forks again
2 participants
@epwalsh @schmmd