Rewrite deadbolt entirely #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Let's go, in and out, quick 20 minute adventure No more javascript -- terrible language. This commit mostly works, but still needs some work on a few TODOs: - Errors not handled on failure to create encrypted file / decrypt file. Something related to electron/electron#24427 - Not always correctly identifying that the encrypted file HAS been created. This is a weird bug - CSS is a bit fucked still
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Awaiting `writeFileWithPromise` does not actually await writing the data to a file... Fucking stupid bug, who hired me to work on this
… verify the file contents after encryption Summary: Test Plan:
alichtman
force-pushed
the
alichtman/electron-upgrade-refactor
branch
3 times, most recently
from
dc3a858 to
a817c56
Compare
alichtman
force-pushed
the
alichtman/electron-upgrade-refactor
branch
from
c5f4b29 to
1d347ca
Compare
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
alichtman
force-pushed
the
alichtman/electron-upgrade-refactor
branch
from
b7ac24e to
d1048f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of the app. I really did not know what I was doing when I worked on this the first time around. I re-read the state management code and decided to torch the whole thing.
Non-exhaustive list of changes:
deadbolt is now written with / in
Typescript 5.7.2,React 18,Node 22, andElectron 31.3.0.Builds for more packaging methods. Mainly excited about
rpm-- I'll start my owndnf coprrepo for easy install on Fedora once I have it workingBetter release ergonomics
Added a automatic SHA256 checksum to verify no corruption during the data encryption + decryption process. Previously, you'd have to decrypt your file to confirm it was encrypted correctly.
File integrity checksum is now actually confirmed on decryption: 9ab1304. We were storing the checksum before, and then ... throwing it away without doing anything with it. Oops.
Added ability to pass error messages from backend to frontend, and added a bunch of friendly error messages
Added password visibility / invisibility toggle
Encryption for folders is possible (they are automatically zipped and encrypted) for drag-and-drop. Not sure how to get selecting folders from the finder working.
Some screenshots: