Fixed some test cases that failed to start the DNS daemon #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chobits
commented
May 28, 2023
•
chobits
commented
- resolver_file.t: reduced dependency on DNS server listening.
- In new github workflow environment, we cannot bind 53 port sometimes. In order to make the case pass, we should remove the dependency on 53 port listening, using debug log to check the logic.
- proxy_connect_*.t: refactored the logic of the DNS daemon test cases to follow the style of the nginx-tests repository.
- When attempting to bind UDP ports fails, retry other random ports
… cases Refactored the logic to follow the style of the nginx-tests repository.
chobits
commented
May 29, 2023
| pack 'n3N nC4', 0xc00c, A, IN, $ttl, eval "scalar $code", eval($code); | ||
| } | ||
|
|
||
| sub dns_daemon { |
There was a problem hiding this comment.
coding style from nginx-tests/http_resolver.t
chobits
changed the title
|
LGTM |
lhanjian
approved these changes
May 29, 2023
chobits
added a commit
to chobits/tengine
that referenced
this pull request
Aug 4, 2023
1. resolver_file.t: reduced dependency on DNS server listening. * In new github workflow environment, we cannot bind 53 port sometimes. In order to make the case pass, we should remove the dependency on 53 port listening, using debug log to check the logic. 2. proxy_connect_*.t: refactored the logic of the DNS daemon test cases to follow the style of the nginx-tests repository. * When attempting to bind UDP ports fails, retry other random ports
jizhuozhi
pushed a commit
to jizhuozhi/tengine
that referenced
this pull request
Nov 6, 2023
1. resolver_file.t: reduced dependency on DNS server listening. * In new github workflow environment, we cannot bind 53 port sometimes. In order to make the case pass, we should remove the dependency on 53 port listening, using debug log to check the logic. 2. proxy_connect_*.t: refactored the logic of the DNS daemon test cases to follow the style of the nginx-tests repository. * When attempting to bind UDP ports fails, retry other random ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.