-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug that client cannot receive right packages with ssl_async enabled #1774
Conversation
For ssl_async feature, the original PR can be found at #993. |
All tengine test cases have passed, with the exception of the resolve_file.t test case, which may have failed due to the GitHub workflow environment blocking port 53 listening. ACK |
We strongly recommend adding your manual testing case to the tengine tests suite at tests/nginx-tests/tengine-tests/http_ssl_asynchronous_mode.t. The test suite can just verify that the ssl response is received. |
@chobits 再看看 |
@wa5i 看看 |
完全同意。但有2个方法可以绕过。
加入测试的好处是,现在tengine项目已经接入github workflow,所有同目录下的*.t文件都会被自动测试,这样防止后续出现异常回滚 关于自动化测试:https://github.com/alibaba/tengine/actions/runs/4890602870/jobs/8730897619 逻辑review过,先合并了 |
issue: There is an error when tengine is running with TLSv1.3, "ssl_early_data on" and "ssl_async on;“. Client can't receive right packages and get the right answer.

nginx.conf:
echo -e "GET / HTTP/1.1\r\nHost: www.test-async.com\r\nConnection: close\r\n\r\n" > request.txt
echo|openssl s_client -connect 127.0.0.1:443 -sess_out session.pem -servername www.test-async.com
openssl client error:



nginx error_log:
openssl client log:





nginx error_log:
nginx access_log: