Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ssl_certificates.t to latest version of nginx-tests #1702

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

chobits
Copy link
Member

@chobits chobits commented Nov 22, 2022

No description provided.

@chobits
Copy link
Member Author

chobits commented Nov 22, 2022

@chobits chobits requested a review from nandsky November 22, 2022 07:14
Copy link
Collaborator

@nandsky nandsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also update https://github.com/alibaba/tengine/blob/master/tests/nginx-tests/nginx-tests/ssl_engine_keys.t#L111?

	system('pkcs11-tool --module=/usr/local/lib/softhsm/libsofthsm.so '
		. '-p 1234 -l -k -d 0 -a nx_key_0 --key-type rsa:1024 '
		. ">>$d/openssl.out 2>&1");

Copy link
Collaborator

@nandsky nandsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandsky nandsky merged commit 6c5c1f4 into alibaba:master Nov 22, 2022
@chobits chobits added this to the 2.4.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants