ci.yml: added tengine test cases using test-nginx lib #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chobits
commented
Nov 11, 2022
•
chobits
commented
- run tengine cases that uses test-nginx lib in tests/test-nginx/cases/ with minor changes
- clear deprecated cases in tests/test-nginx/cases/ (these features had been replaced by nginx, so the cases are deprecated.
- fixed accidental failure of some test cases in github CI/CD workflow: fastcgi_check.t and reqstat.t
1. modified ci.yml: run tengine test cases using test-nginx lib 2. remove deprecated syslog.t and limit_upstream_tries.t (this feature is replaced by similar one from nginx 3. fixed user_agent.t: remove ngx_echo dependence via using "return" directive
Use "127.0.0.01:8xxx" instead of "127.0.0.1:8xxx". Otherwise, port() in Nginx.pm will listen on that port firstly, which makes fastcgi_daemon() fail to open port.
|
After this pr, only nginx-tests/*.t are not included into CI/CD workflow. See those cases in https://github.com/alibaba/tengine/tree/master/tests/nginx-tests/nginx-tests May create a new workflow action(new .yml file) for nginx-tests/*.t, too many cases here. |
|
cc @u5surf for modifying ci.yml |
chobits
commented
Nov 11, 2022
| @@ -19,23 +19,23 @@ __DATA__ | |||
| --- config | |||
| location /exact { | |||
| if ($browser = 1) { | |||
| echo "msie6"; | |||
| return 200 "msie6\n"; | |||
There was a problem hiding this comment.
remove dependence of ngx_echo module.
|
new added cases see here: https://github.com/alibaba/tengine/actions/runs/3444860481/jobs/5747915651
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.