tengine tests cases: fixed some failed test cases #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chobits
commented
Oct 29, 2022
•
chobits
commented
- fixed tengine-tests/consistant_hash.t: must listen on 127.0.0.1, otherwise http_get() will fail to connect server. Nginx.pm:port(8080) will return random port number if there is not "127.0.0.1:" in nginx.conf.
- remove deprecated cases of "error_page default"
- clear deprecated tengine dso cases
- fixed tengine-tests/resolver.t: taobao.com server replies a different status code
- new added tengine-tests/resolver_file.t: test "resolver_file" directive, that resolver.t only tests configure loading
If "127.0.0.1:8080" is not included in nginx.conf in test case, function port(8080) in Test::Nginx will fail to test listening on "127.0.0.1:8080".
* The old test case tengine-tests/resolver.t can only test whether the "resolver_file" directive is loaded successfully. * The new test case can check whether the resolver server loaded from "resolver_file" works.
chobits
commented
Oct 29, 2022
| @@ -230,7 +230,7 @@ EOF | |||
|
|
|||
| $t->run(); | |||
|
|
|||
| like(http_get_host("/", "www.taobao.com"), qr/HTTP\/1.1 302/, 'resolver_file to resolv4.conf'); | |||
| like(http_get_host("/", "www.taobao.com"), qr/HTTP\/1.1 \d\d\d/, 'resolver_file to resolv4.conf'); | |||
There was a problem hiding this comment.
www.taobao.com replys 301 currenlty.
This is not a good test case. It depends on an external uncontrollable backend server.
So I create a new test case in this pr: resolver_file.t.
Closed
|
@wangfakang will ack this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.