Skip to content

fix: Hide nacos password when nacos-registration fails #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ruansheng8
Copy link
Collaborator

Describe what this PR does / why we need it

控制台日志可能被各类组件抽取到不同的地方,因此在控制台日志中隐藏 Nacos 帐号密码等敏感信息。
See #3837

@ruansheng8
Copy link
Collaborator Author

PTAL @yuluo-yx @chickenlj

Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@yuluo-yx yuluo-yx merged commit 26609b7 into alibaba:2023.x Sep 3, 2024
3 checks passed
@ruansheng8 ruansheng8 added the waiting for sync waiting for sync to other main branchs label Sep 4, 2024
Copy link

@wallellen wallellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个直接将NacosRegistration中的nacosDiscoveryProperties给清空了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for sync waiting for sync to other main branchs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants