feat:move warning logs to a more suitable location(#3570) #3578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuluo-yx
reviewed
Jan 5, 2024
...ba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/loadbalancer/NacosLoadBalancer.java
Show resolved
Hide resolved
yuluo-yx
reviewed
Jan 5, 2024
...ba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/loadbalancer/NacosLoadBalancer.java
Show resolved
Hide resolved
|
Do you have any questions or new ideas about the above code? I found that this PR seems to have stalled😂. |
The community will review your submission soon, please wait patiently. 🤔 |
|
@Suzzt Can you pls solve the ci failed. https://github.com/alibaba/spring-cloud-alibaba/actions/runs/9013434028/job/24764358969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
When Nacos made cross cluster calls, it was found that there was no warning log like "A cross cluster call occurrences..." in previous versions
Does this pull request fix one issue?
Feat##3570
Describe how you did it
Move the error warning log to the appropriate location so that the warning prompt can be printed correctly and reasonably
Describe how to verify it
NONE
Special notes for reviews
NONE