Merge pull request #278 from hhyasdf/release/v0.5.1

[CHERRY PICK] fix address duplication error while active-standby switch happens

Author: mars1024

cmd/manager/main.go

@@ -116,6 +116,9 @@ func main() {
 		}
 	}()
 
+	// Initialization should be after leader election success
+	<-mgr.Elected()
+
 	// wait for manager cache client ready
 	mgr.GetCache().WaitForCacheSync(globalContext)
 

pkg/controllers/networking/pod_controller.go

@@ -129,6 +129,11 @@ func (r *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (result
 			(len(ipInstanceList) == 2 && ipFamily == ipamtypes.DualStack) {
 			return ctrl.Result{}, nil
 		}
+
+		if len(ipInstanceList) > 0 {
+			return ctrl.Result{}, fmt.Errorf("duplicated ip instances exist for pod: %v/%v, pod ip family is %v",
+				pod.Namespace, pod.Name, ipFamily)
+		}
 	}
 
 	networkName, err = r.selectNetwork(ctx, pod)

pkg/controllers/networking/pod_ip_cache.go

@@ -99,6 +99,9 @@ func NewPodIPCache(ctx context.Context, c client.Reader, logger logr.Logger) (Po
 				recordedIPInstances = cache.podToIP[namespacedKey(podName, ip.Namespace)].ipInstanceNames
 			}
 
+			logger.V(1).Info("add record to init cache", "ip",
+				ip.Name, "namespace", ip.Namespace, "pod", podName, "pod uid", podUID)
+
 			// this is different from a normal Record action
 			cache.podToIP[namespacedKey(podName, ip.Namespace)] = &podAllocatedInfo{
 				podUID:          podUID,